Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only clean default project when building workspace if it exists. #3154

Merged
merged 1 commit into from
May 9, 2024
Merged

Only clean default project when building workspace if it exists. #3154

merged 1 commit into from
May 9, 2024

Conversation

ethan-vanderheijden
Copy link
Contributor

Fixes #3153

@eclipse-ls-bot
Copy link
Contributor

Can one of the admins verify this patch?

@snjeza snjeza requested a review from rgrunber May 9, 2024 02:44
@snjeza
Copy link
Contributor

snjeza commented May 9, 2024

@rgrunber Could you, please, review this PR?

rgrunber
rgrunber approved these changes May 9, 2024
View reviewed changes
Copy link
Contributor

@rgrunber rgrunber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Makes a lot more sense than what I had initially.

@fbricon fbricon merged commit 185a7cd into eclipse-jdtls:master May 9, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgrunber rgrunber rgrunber approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tries to clean default workspace when it doesn't exist.
5 participants
@ethan-vanderheijden @eclipse-ls-bot @snjeza @rgrunber @fbricon